refactor: ibk 은행 점검 이후 로그인 페이지 롤백 - #182
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review infoConfiguration used: Organization UI Review profile: CHILL Plan: Pro Cache: Disabled due to data retention organization setting Knowledge base: Disabled due to data retention organization setting 📒 Files selected for processing (1)
WalkthroughLoginPage 컴포넌트에서 유지보수 관련 로직(유지보수 판정, 상태 변수, 모달)과 해당 초기화 이펙트를 제거하고, Google 로그인·홈페이지·Gmail 가이드를 항상 표시하도록 렌더 흐름을 단순화했습니다. Google 버튼/링크 및 Gmail 가이드에 분석(analytics) 호출이 추가되었습니다. Changes
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@src/pages/LoginPage.tsx`:
- Around line 46-51: The Analytics.safeTrack call inside the Button onClick for
"Go_Homepage_Click" is sending method: "Email", which mislabels the action;
update the payload in the Analytics.safeTrack invocation (the object with
category and method) to use a value that reflects navigation to the homepage
(e.g., method: "Homepage" or "Navigation") so the event name "Go_Homepage_Click"
and method field are consistent.
ℹ️ Review info
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge base: Disabled due to data retention organization setting
📒 Files selected for processing (1)
src/pages/LoginPage.tsx
1 participant
Summary by CodeRabbit
릴리스 노트